feat(agents): introduce agent provisioning domain and proto - #480
Merged
Conversation
PR SummaryMedium Risk Overview ADR#0040 drives breaking proto renames on undeployed session types: Adds draft ADRs 0036–0039 (self-certifying identity, governed verification vs permissionless Nostr, Ed25519/ CI: the proto breaking job is skipped when the PR has label Reviewed by Cursor Bugbot for commit 8e65e18. Bugbot is set up for automated code reviews on this repo. Configure here. |
yordis
force-pushed
the
yordis/audit-agent-context-doc
branch
from
July 13, 2026 16:17
af1cb66 to
f0a0d07
Compare
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds versioned agent metadata and provisioning-event protobuf schemas, exposes generated agent types through the Rust protocol crate, enables the required feature dependencies, and adds codec tests for event encoding, decoding, dispatch, and error handling. ChangesAgent provisioning foundation
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (9)
rsworkspace/crates/trogonai-agents-domain/src/commands/archive_agent.rs (1)
127-145: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDuplicate
lifecycle()helper across deciders. Both files define a byte-for-byte identical helper (state lookup →as_known()fallback → UNSPECIFIED rejection), differing only in the generated proto type names; the shared root cause is the lack of a common lifecycle-extraction abstraction forstate_v1::*::Lifecycleenums.
rsworkspace/crates/trogonai-agents-domain/src/commands/archive_agent.rs#L127-L145: extract this logic into a shared generic helper (e.g. a small macro or trait over the state/Lifecycletype) inevent_fold.rsand delegate to it here.rsworkspace/crates/trogonai-agents-domain/src/commands/activate_revision.rs#L241-L259: delegate to the same shared helper instead of re-defining an identical function.This pattern likely recurs in the other decider files in this PR (
provision_agent.rs,stage_revision.rs,record_revision_verdict.rs,rollback_revision.rs), which aren't in the current review batch — worth confirming and extending the extraction to those as well.♻️ Example extraction sketch
// event_fold.rs pub(crate) fn known_lifecycle<L>( lifecycle: &Option<buffa::EnumValue<L>>, ) -> Result<L, AgentEventFoldError> where L: Copy + PartialEq + buffa::EnumFullName, // adjust bound to whatever buffa exposes { let value = lifecycle.as_ref().ok_or(AgentEventFoldError::MissingStateField("lifecycle"))?; let known = value.as_known().ok_or(AgentEventFoldError::UnknownStateValue { field: "lifecycle", value: value.to_i32(), })?; Ok(known) }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@rsworkspace/crates/trogonai-agents-domain/src/commands/archive_agent.rs` around lines 127 - 145, The lifecycle extraction logic is duplicated across deciders; add a shared generic helper in rsworkspace/crates/trogonai-agents-domain/src/event_fold.rs and preserve missing-field, unknown-value, and UNSPECIFIED rejection behavior. Update lifecycle() in rsworkspace/crates/trogonai-agents-domain/src/commands/archive_agent.rs (lines 127-145) and rsworkspace/crates/trogonai-agents-domain/src/commands/activate_revision.rs (lines 241-259) to delegate to it, and inspect provision_agent.rs, stage_revision.rs, record_revision_verdict.rs, and rollback_revision.rs for the same pattern, extending the shared helper usage where present.rsworkspace/crates/trogonai-agents-domain/src/commands/stage_revision/tests.rs (1)
59-71: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsider adding a test for change-class overstatement.
The existing test covers understatement (declared
LearnedLayerbut requiredCharter). Thedecidefunction rejects both directions via the same!=check, but a test for the overstatement direction (declaredCharterbut requiredLearnedLayer) would document that explicitly.🧪 Suggested overstatement test
+ +#[test] +fn rejects_a_change_class_that_overstates_the_change() { + let mut command = stage_command(revision_two(), ChangeClass::LearnedLayer); + command.change_class = ChangeClass::Charter; + + TestCase::<StageRevision>::new() + .given([provisioned_event()]) + .when(command) + .then_error(StageRevisionError::ChangeClassMismatch { + declared: ChangeClass::Charter, + required: ChangeClass::LearnedLayer, + }); +}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@rsworkspace/crates/trogonai-agents-domain/src/commands/stage_revision/tests.rs` around lines 59 - 71, Add a test alongside rejects_a_change_class_that_understates_the_change covering overstatement: use a revision requiring ChangeClass::LearnedLayer, declare ChangeClass::Charter, and assert StageRevisionError::ChangeClassMismatch with declared Charter and required LearnedLayer.rsworkspace/crates/trogonai-agents-domain/src/commands/domain/tool_selectors/tests.rs (1)
3-18: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd tests for
InvalidRequiredandInvalidOptionalerror variants.The test covers the happy path and
Overlap, butToolSelectorsError::InvalidRequiredandToolSelectorsError::InvalidOptional(blank/untrimmed selectors) are untested.✅ Suggested additional test cases
#[test] fn validates_ordered_disjoint_tool_selectors() { let selectors = ToolSelectors::new( BTreeSet::from(["bash".to_string()]), BTreeSet::from(["web_search".to_string()]), ) .unwrap(); assert!(selectors.required().contains("bash")); assert!(matches!( ToolSelectors::new( BTreeSet::from(["bash".to_string()]), BTreeSet::from(["bash".to_string()]) ), Err(ToolSelectorsError::Overlap { .. }) )); } + +#[test] +fn rejects_blank_required_selector() { + assert!(matches!( + ToolSelectors::new( + BTreeSet::from(["".to_string()]), + BTreeSet::new(), + ), + Err(ToolSelectorsError::InvalidRequired { .. }) + )); +} + +#[test] +fn rejects_blank_optional_selector() { + assert!(matches!( + ToolSelectors::new( + BTreeSet::new(), + BTreeSet::from(["".to_string()]), + ), + Err(ToolSelectorsError::InvalidOptional { .. }) + )); +}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@rsworkspace/crates/trogonai-agents-domain/src/commands/domain/tool_selectors/tests.rs` around lines 3 - 18, Add test cases in validates_ordered_disjoint_tool_selectors for ToolSelectors::new returning ToolSelectorsError::InvalidRequired when a required selector is blank or untrimmed, and InvalidOptional for the corresponding optional selector inputs. Assert the specific error variants while preserving the existing valid and Overlap coverage.rsworkspace/crates/trogonai-agents-domain/src/commands/domain/tool_selectors.rs (1)
5-8: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winExtract a
ToolSelectorvalue object to align with domain modeling guidelines.
ToolSelectorsstores individual selector names as bareStringprimitives and validates nonblank/trimmed at the aggregate level. The coding guidelines require preferring domain-specific value objects over primitives and validating per-type, not per-aggregate. AToolSelectorvalue object would move the nonblank/trimmed check to its ownnewconstructor, leavingToolSelectors::newresponsible only for the overlap constraint. This also eliminatesInvalidRequired/InvalidOptionalfromToolSelectorsErrorand preserves the originalNonblankErrorcontext instead of discarding it via.is_err().As per coding guidelines: "Prefer domain-specific value objects over primitives (e.g.,
AcpPrefixinstead ofString)" and "Validate per-type, not per-aggregate: avoid validating unrelated fields together in a single constructor."♻️ Proposed refactor sketch
use std::collections::BTreeSet; -use super::nonblank::validate_nonblank; +use super::nonblank::validate_nonblank; + +#[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord)] +pub struct ToolSelector(String); + +#[derive(Debug, Clone, PartialEq, Eq, thiserror::Error)] +pub enum ToolSelectorError { + #[error("tool selector '{selector}' must be nonblank and trimmed")] + Invalid { selector: String }, +} + +impl ToolSelector { + pub fn new(selector: String) -> Result<Self, ToolSelectorError> { + validate_nonblank(&selector).map_err(|_| ToolSelectorError::Invalid { selector })?; + Ok(Self(selector)) + } + + pub fn as_str(&self) -> &str { + &self.0 + } +} #[derive(Debug, Clone, PartialEq, Eq, Default)] pub struct ToolSelectors { - required: BTreeSet<String>, - optional: BTreeSet<String>, + required: BTreeSet<ToolSelector>, + optional: BTreeSet<ToolSelector>, } #[derive(Debug, Clone, PartialEq, Eq, thiserror::Error)] pub enum ToolSelectorsError { - #[error("required tool selector '{selector}' must be nonblank and trimmed")] - InvalidRequired { selector: String }, - #[error("optional tool selector '{selector}' must be nonblank and trimmed")] - InvalidOptional { selector: String }, #[error("tool selector '{selector}' cannot be both required and optional")] - Overlap { selector: String }, + Overlap { selector: ToolSelector }, } impl ToolSelectors { - pub fn new(required: BTreeSet<String>, optional: BTreeSet<String>) -> Result<Self, ToolSelectorsError> { - for selector in &required { - if validate_nonblank(selector).is_err() { - return Err(ToolSelectorsError::InvalidRequired { - selector: selector.clone(), - }); - } - } - for selector in &optional { - if validate_nonblank(selector).is_err() { - return Err(ToolSelectorsError::InvalidOptional { - selector: selector.clone(), - }); - } - } + pub fn new(required: BTreeSet<ToolSelector>, optional: BTreeSet<ToolSelector>) -> Result<Self, ToolSelectorsError> { if let Some(selector) = required.intersection(&optional).next() { return Err(ToolSelectorsError::Overlap { selector: selector.clone(), }); } Ok(Self { required, optional }) } - pub fn required(&self) -> &BTreeSet<String> { + pub fn required(&self) -> &BTreeSet<ToolSelector> { &self.required } - pub fn optional(&self) -> &BTreeSet<String> { + pub fn optional(&self) -> &BTreeSet<ToolSelector> { &self.optional } }Also applies to: 22-43
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@rsworkspace/crates/trogonai-agents-domain/src/commands/domain/tool_selectors.rs` around lines 5 - 8, Introduce a domain-specific ToolSelector value object with a new constructor that validates and preserves the existing NonblankError for nonblank, trimmed selector names. Update ToolSelectors.required and optional to store ToolSelector values, and adjust construction/accessors as needed. Make ToolSelectors::new enforce only the required/optional overlap constraint, removing InvalidRequired and InvalidOptional from ToolSelectorsError and propagating ToolSelector construction errors unchanged.Source: Coding guidelines
rsworkspace/crates/trogonai-agents-domain/src/commands/domain/delegate_selectors.rs (1)
5-9: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse a selector value object instead of raw
String
nonblank.rsonly providesvalidate_nonblank, soDelegateSelectorsandToolSelectorsstill validate individual strings themselves. A dedicated selector type would make invalid selectors unrepresentable and leave these aggregates to enforce only overlap.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@rsworkspace/crates/trogonai-agents-domain/src/commands/domain/delegate_selectors.rs` around lines 5 - 9, Introduce a dedicated selector value object validated through the existing nonblank validation, and replace the raw String element types in DelegateSelectors’ required and optional BTreeSets with that type. Update ToolSelectors and related construction/access paths consistently so individual selector validation is centralized in the value object, while the aggregate types enforce only required/optional overlap rules.Source: Coding guidelines
rsworkspace/crates/trogonai-agents-domain/src/commands/domain/rollback_reason.rs (1)
3-32: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsider dedicated value types for
metric/window/deltainstead of rawString.Each field is independently validated for nonblank inside a single shared constructor rather than owning its own factory/type. As per coding guidelines: "Prefer domain-specific value objects over primitives (e.g.,
AcpPrefixinstead ofString)" and "Validate per-type, not per-aggregate: avoid validating unrelated fields together in a single constructor." Other value objects in this PR (SkillRef,TemplateId,TenantId) follow the per-type pattern;RollbackReasoncurrently doesn't.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@rsworkspace/crates/trogonai-agents-domain/src/commands/domain/rollback_reason.rs` around lines 3 - 32, Introduce dedicated domain value types for the metric, window, and delta fields, each owning its nonblank-and-trimmed validation and exposing its own constructor or factory. Update RollbackReason and its constructor to accept and store those value types, removing the per-field primitive validation from RollbackReason while preserving the existing InvalidMetric, InvalidWindow, and InvalidDelta error behavior through the respective type boundaries.Source: Coding guidelines
rsworkspace/crates/trogonai-agents-domain/src/commands/domain/verdict_reasons.rs (1)
9-13: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winConsider including the raw input in
VerdictReasonsErrorfor diagnostic parity.
TenantIdErrorcaptures the raw input (raw: String) for better error messages, butVerdictReasonsErroronly stores theNonBlankViolation. Adding the raw value would make error messages more actionable and maintain consistency across domain error types.♻️ Proposed refactor to include raw input
#[derive(Debug, Clone, PartialEq, Eq, thiserror::Error)] -#[error("verdict reasons are invalid: {violation}")] +#[error("verdict reasons '{raw}' are invalid: {violation}")] pub struct VerdictReasonsError { + raw: String, violation: NonBlankViolation, }Then update the
parsemethod:pub fn parse(raw: &str) -> Result<Self, VerdictReasonsError> { - validate_nonblank(raw).map_err(|violation| VerdictReasonsError { violation })?; + validate_nonblank(raw).map_err(|violation| VerdictReasonsError { + raw: raw.to_string(), + violation, + })?; Ok(Self(raw.to_string())) }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@rsworkspace/crates/trogonai-agents-domain/src/commands/domain/verdict_reasons.rs` around lines 9 - 13, Update VerdictReasonsError and the VerdictReasons::parse flow to retain the original raw input alongside NonBlankViolation, following the TenantIdError pattern. Include the raw value in the error display while preserving the existing validation behavior and violation details.rsworkspace/crates/trogonai-agents-domain/src/commands/domain/evidence/tests.rs (2)
22-40: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider asserting
outcome_refsordering alongsidesession_refs.The test verifies
session_refsare deterministically ordered but doesn't assertoutcome_refscontent or ordering, leaving that path unverified.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@rsworkspace/crates/trogonai-agents-domain/src/commands/domain/evidence/tests.rs` around lines 22 - 40, Extend stores_references_deterministically to also inspect evidence.outcome_refs(), mapping each OutcomeRef with as_str and asserting the collected values equal the expected deterministic order, such as ["outcome-1"].
5-19: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider adding test cases for whitespace violation and both-invalid scenario.
The test covers the empty-rationale and empty-refs cases separately, but doesn't test:
SurroundingWhitespaceviolation (e.g.," reason "should also returnInvalidRationale).- The both-invalid case (empty refs + empty rationale) to document which error takes priority.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@rsworkspace/crates/trogonai-agents-domain/src/commands/domain/evidence/tests.rs` around lines 5 - 19, Extend requires_nonblank_rationale_and_at_least_one_typed_ref to assert that whitespace-surrounded rationale such as " reason " returns EvidenceError::InvalidRationale, and add a case with both empty references and empty rationale to document the constructor’s error precedence. Use Evidence::new and the existing error variants, preserving the current separate validation cases.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@rsworkspace/crates/trogonai-agents-domain/src/commands/domain/archive_reason.rs`:
- Around line 9-18: Update ArchiveReasonError and ArchiveReason::parse to retain
the invalid raw input as a String and include it in the error display, matching
the raw-capturing behavior of ModelIdError, SessionRefError, and AgentIdError
while preserving the existing violation details.
In
`@rsworkspace/crates/trogonai-agents-domain/src/commands/domain/changed_fields.rs`:
- Around line 17-39: Move the immutable-field validation from classify() into
new(), returning ChangedFieldsError::ImmutableFields for any immutable entries
after the empty-set check. Make classify() infallible while preserving its
Charter versus LearnedLayer classification, and update changed_fields tests so
construction asserts the immutable error and classification calls no longer
unwrap a Result.
In
`@rsworkspace/crates/trogonai-agents-domain/src/commands/domain/changed_fields/tests.rs`:
- Around line 21-32: Update the test around ChangedFields::new to assert that
construction directly returns Err(ChangedFieldsError::ImmutableFields { fields:
BTreeSet::from([ChangedField::Name, ChangedField::Runtime]) }). Remove the
unwrap and classify() error assertion, while preserving the existing
immutable-field set.
In `@rsworkspace/crates/trogonai-agents-domain/src/commands/domain/nonblank.rs`:
- Around line 3-7: Add a std::error::Error implementation for the
NonBlankViolation enum in nonblank.rs, preserving its existing Display behavior
and variants.
In
`@rsworkspace/crates/trogonai-agents-domain/src/commands/domain/rubric_result/tests.rs`:
- Around line 5-13: Update the RubricResult construction test to assert the
baseline score through result.baseline().get(), expecting 0.7, alongside the
existing rubric, candidate, and trials assertions.
In `@rsworkspace/crates/trogonai-proto/src/agents/agents/codec/tests.rs`:
- Around line 183-199: The test
event_decode_dispatches_all_lifecycle_event_types overstates coverage. Either
rename it to reflect that it only dispatches AgentProvisioned and AgentArchived,
or extend its EventDecode::decode assertions to include RevisionStaged,
RevisionVerdictRecorded, RevisionActivated, and RevisionRolledBack, preserving
the existing variant-matching style.
---
Nitpick comments:
In `@rsworkspace/crates/trogonai-agents-domain/src/commands/archive_agent.rs`:
- Around line 127-145: The lifecycle extraction logic is duplicated across
deciders; add a shared generic helper in
rsworkspace/crates/trogonai-agents-domain/src/event_fold.rs and preserve
missing-field, unknown-value, and UNSPECIFIED rejection behavior. Update
lifecycle() in
rsworkspace/crates/trogonai-agents-domain/src/commands/archive_agent.rs (lines
127-145) and
rsworkspace/crates/trogonai-agents-domain/src/commands/activate_revision.rs
(lines 241-259) to delegate to it, and inspect provision_agent.rs,
stage_revision.rs, record_revision_verdict.rs, and rollback_revision.rs for the
same pattern, extending the shared helper usage where present.
In
`@rsworkspace/crates/trogonai-agents-domain/src/commands/domain/delegate_selectors.rs`:
- Around line 5-9: Introduce a dedicated selector value object validated through
the existing nonblank validation, and replace the raw String element types in
DelegateSelectors’ required and optional BTreeSets with that type. Update
ToolSelectors and related construction/access paths consistently so individual
selector validation is centralized in the value object, while the aggregate
types enforce only required/optional overlap rules.
In
`@rsworkspace/crates/trogonai-agents-domain/src/commands/domain/evidence/tests.rs`:
- Around line 22-40: Extend stores_references_deterministically to also inspect
evidence.outcome_refs(), mapping each OutcomeRef with as_str and asserting the
collected values equal the expected deterministic order, such as ["outcome-1"].
- Around line 5-19: Extend
requires_nonblank_rationale_and_at_least_one_typed_ref to assert that
whitespace-surrounded rationale such as " reason " returns
EvidenceError::InvalidRationale, and add a case with both empty references and
empty rationale to document the constructor’s error precedence. Use
Evidence::new and the existing error variants, preserving the current separate
validation cases.
In
`@rsworkspace/crates/trogonai-agents-domain/src/commands/domain/rollback_reason.rs`:
- Around line 3-32: Introduce dedicated domain value types for the metric,
window, and delta fields, each owning its nonblank-and-trimmed validation and
exposing its own constructor or factory. Update RollbackReason and its
constructor to accept and store those value types, removing the per-field
primitive validation from RollbackReason while preserving the existing
InvalidMetric, InvalidWindow, and InvalidDelta error behavior through the
respective type boundaries.
In
`@rsworkspace/crates/trogonai-agents-domain/src/commands/domain/tool_selectors.rs`:
- Around line 5-8: Introduce a domain-specific ToolSelector value object with a
new constructor that validates and preserves the existing NonblankError for
nonblank, trimmed selector names. Update ToolSelectors.required and optional to
store ToolSelector values, and adjust construction/accessors as needed. Make
ToolSelectors::new enforce only the required/optional overlap constraint,
removing InvalidRequired and InvalidOptional from ToolSelectorsError and
propagating ToolSelector construction errors unchanged.
In
`@rsworkspace/crates/trogonai-agents-domain/src/commands/domain/tool_selectors/tests.rs`:
- Around line 3-18: Add test cases in validates_ordered_disjoint_tool_selectors
for ToolSelectors::new returning ToolSelectorsError::InvalidRequired when a
required selector is blank or untrimmed, and InvalidOptional for the
corresponding optional selector inputs. Assert the specific error variants while
preserving the existing valid and Overlap coverage.
In
`@rsworkspace/crates/trogonai-agents-domain/src/commands/domain/verdict_reasons.rs`:
- Around line 9-13: Update VerdictReasonsError and the VerdictReasons::parse
flow to retain the original raw input alongside NonBlankViolation, following the
TenantIdError pattern. Include the raw value in the error display while
preserving the existing validation behavior and violation details.
In
`@rsworkspace/crates/trogonai-agents-domain/src/commands/stage_revision/tests.rs`:
- Around line 59-71: Add a test alongside
rejects_a_change_class_that_understates_the_change covering overstatement: use a
revision requiring ChangeClass::LearnedLayer, declare ChangeClass::Charter, and
assert StageRevisionError::ChangeClassMismatch with declared Charter and
required LearnedLayer.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f267a30d-9645-43ae-8f8f-17c80be9afad
⛔ Files ignored due to path filters (46)
rsworkspace/Cargo.lockis excluded by!**/*.lockrsworkspace/crates/trogonai-proto/src/gen/mod.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.state.v1.activate_revision_state.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.state.v1.activate_revision_state.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.state.v1.archive_agent_state.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.state.v1.archive_agent_state.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.state.v1.mod.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.state.v1.provision_agent_state.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.state.v1.provision_agent_state.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.state.v1.record_revision_verdict_state.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.state.v1.record_revision_verdict_state.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.state.v1.rollback_revision_state.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.state.v1.rollback_revision_state.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.state.v1.stage_revision_state.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.state.v1.stage_revision_state.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.activate_revision.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.activate_revision.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.agent.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.agent.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.agent_archived.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.agent_archived.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.agent_provisioned.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.agent_provisioned.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.archive_agent.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.archive_agent.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.events.__oneof.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.events.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.events.__view_oneof.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.events.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.mod.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.provision_agent.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.provision_agent.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.record_revision_verdict.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.record_revision_verdict.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.revision_activated.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.revision_activated.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.revision_rolled_back.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.revision_rolled_back.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.revision_staged.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.revision_staged.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.revision_verdict_recorded.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.revision_verdict_recorded.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.rollback_revision.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.rollback_revision.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.stage_revision.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.stage_revision.rsis excluded by!**/gen/**
📒 Files selected for processing (137)
docs/architecture/agent-platform/research/decision-record.mddocs/architecture/agent-platform/research/index.mddocs/architecture/agent-platform/research/products/adk-a2a.mddocs/architecture/agent-platform/research/products/bedrock-agentcore.mddocs/architecture/agent-platform/research/products/claude-code-agent-sdk.mddocs/architecture/agent-platform/research/products/claude-managed-agents.mddocs/architecture/agent-platform/research/products/cloudflare-agents.mddocs/architecture/agent-platform/research/products/crewai.mddocs/architecture/agent-platform/research/products/devin.mddocs/architecture/agent-platform/research/products/hermes-agent.mddocs/architecture/agent-platform/research/products/jido.mddocs/architecture/agent-platform/research/products/langgraph-platform.mddocs/architecture/agent-platform/research/products/netclaw.mddocs/architecture/agent-platform/research/products/openai-agents-sdk.mddocs/architecture/agent-platform/research/products/openclaw.mddocs/architecture/agent-platform/research/products/opencomputer.mddocs/architecture/agent-platform/research/products/vercel.mddocs/architecture/agent-platform/research/synthesis.mdproto/trogonai/agents/agents/state/v1/activate_revision_state.protoproto/trogonai/agents/agents/state/v1/archive_agent_state.protoproto/trogonai/agents/agents/state/v1/provision_agent_state.protoproto/trogonai/agents/agents/state/v1/record_revision_verdict_state.protoproto/trogonai/agents/agents/state/v1/rollback_revision_state.protoproto/trogonai/agents/agents/state/v1/stage_revision_state.protoproto/trogonai/agents/agents/v1/activate_revision.protoproto/trogonai/agents/agents/v1/agent.protoproto/trogonai/agents/agents/v1/agent_archived.protoproto/trogonai/agents/agents/v1/agent_provisioned.protoproto/trogonai/agents/agents/v1/archive_agent.protoproto/trogonai/agents/agents/v1/events.protoproto/trogonai/agents/agents/v1/provision_agent.protoproto/trogonai/agents/agents/v1/record_revision_verdict.protoproto/trogonai/agents/agents/v1/revision_activated.protoproto/trogonai/agents/agents/v1/revision_rolled_back.protoproto/trogonai/agents/agents/v1/revision_staged.protoproto/trogonai/agents/agents/v1/revision_verdict_recorded.protoproto/trogonai/agents/agents/v1/rollback_revision.protoproto/trogonai/agents/agents/v1/stage_revision.protorsworkspace/crates/trogon-decider-sim/Cargo.tomlrsworkspace/crates/trogon-decider-sim/src/fixture.rsrsworkspace/crates/trogon-decider-sim/tests/agents.rsrsworkspace/crates/trogonai-agents-domain/Cargo.tomlrsworkspace/crates/trogonai-agents-domain/src/commands/activate_revision.rsrsworkspace/crates/trogonai-agents-domain/src/commands/activate_revision/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/archive_agent.rsrsworkspace/crates/trogonai-agents-domain/src/commands/archive_agent/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_charter.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_charter/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_definition.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_definition/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_id.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_id/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_name.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_name/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/annotations.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/annotations/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/archive_reason.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/archive_reason/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/change_class.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/change_class/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/change_summary.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/change_summary/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/changed_field.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/changed_field/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/changed_fields.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/changed_fields/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/content_digest.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/content_digest/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/delegate_selectors.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/delegate_selectors/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/evidence.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/evidence/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/kubernetes_syntax.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/labels.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/labels/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/mod.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/model_id.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/model_id/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/model_parameters.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/model_parameters/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/nonblank.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/outcome_ref.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/outcome_ref/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/parent_ref.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/parent_ref/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/principal.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/principal/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/revision_number.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/revision_number/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/rollback_reason.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/rollback_reason/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/rubric_ref.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/rubric_ref/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/rubric_result.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/rubric_result/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/rubric_score.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/rubric_score/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/runtime_id.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/runtime_id/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/session_ref.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/session_ref/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/skill_ref.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/skill_ref/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/template_id.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/template_id/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/tenant_id.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/tenant_id/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/tool_selectors.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/tool_selectors/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/trial_count.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/trial_count/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/verdict.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/verdict/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/verdict_reasons.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/verdict_reasons/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/event_fold.rsrsworkspace/crates/trogonai-agents-domain/src/commands/lifecycle_tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/mod.rsrsworkspace/crates/trogonai-agents-domain/src/commands/proto_wire.rsrsworkspace/crates/trogonai-agents-domain/src/commands/proto_wire/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/provision_agent.rsrsworkspace/crates/trogonai-agents-domain/src/commands/provision_agent/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/record_revision_verdict.rsrsworkspace/crates/trogonai-agents-domain/src/commands/record_revision_verdict/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/rollback_revision.rsrsworkspace/crates/trogonai-agents-domain/src/commands/rollback_revision/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/stage_revision.rsrsworkspace/crates/trogonai-agents-domain/src/commands/stage_revision/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/test_support.rsrsworkspace/crates/trogonai-agents-domain/src/lib.rsrsworkspace/crates/trogonai-proto/Cargo.tomlrsworkspace/crates/trogonai-proto/src/agents/agents/codec.rsrsworkspace/crates/trogonai-proto/src/agents/agents/codec/tests.rsrsworkspace/crates/trogonai-proto/src/agents/agents/mod.rsrsworkspace/crates/trogonai-proto/src/agents/mod.rsrsworkspace/crates/trogonai-proto/src/lib.rsrsworkspace/crates/trogonai-proto/src/tests.rs
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
yordis
force-pushed
the
yordis/audit-agent-context-doc
branch
from
July 18, 2026 22:50
c2797f1 to
91eea77
Compare
yordis
force-pushed
the
yordis/audit-agent-context-doc
branch
from
July 19, 2026 20:01
a745f80 to
2273e40
Compare
|
Code Coverage SummaryDetailsDiff against mainResults for commit: 8e65e18 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
yordis
added
the
rust:coverage-baseline-reset
yordis
changed the title
There was a problem hiding this comment.
Pull request overview
Introduces an initial “agents provisioning” boundary across the wire (protobuf) and domain layers, so the system can treat provisioning as an independently evolvable contract before broader agent proposal/revision workflows expand.
Changes:
- Add agent provisioning proto schema (command, event union, and state snapshot) plus generated Rust bindings.
- Extend
trogonai-protoevent JSON decoding registry/tests to include agent events. - Introduce
trogonai-agents-domaincrate implementing a Wasm-clean provisioning decider plus typed validation and wire↔domain conversion.
Reviewed changes
Copilot reviewed 70 out of 71 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rsworkspace/crates/trogonai-proto/src/tests.rs | Adds agent-related decoding tests and feature-gates schedule-only helpers. |
| rsworkspace/crates/trogonai-proto/src/lib.rs | Registers agent proto types in the JSON decode registry and loosens feature gating to `schedules |
| rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.provision_agent.rs | Generated Rust message for the ProvisionAgent command. |
| rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.provision_agent.__view.rs | Generated borrow/view API for ProvisionAgent. |
| rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.mod.rs | Generated module glue and type registration for agent v1 package. |
| rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.events.rs | Generated AgentEvent oneof wrapper and JSON-any registration. |
| rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.events.__view.rs | Generated view API for AgentEvent. |
| rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.events.__view_oneof.rs | Generated view oneof enum for AgentEvent. |
| rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.events.__oneof.rs | Generated owned oneof enum for AgentEvent. |
| rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.agent_provisioned.rs | Generated Rust message for AgentProvisioned genesis event. |
| rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.agent_provisioned.__view.rs | Generated borrow/view API for AgentProvisioned. |
| rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.state.v1.provision_agent_state.rs | Generated Rust messages for provisioning state snapshot and identity subset. |
| rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.state.v1.mod.rs | Generated module glue and type registration for agent state v1 package. |
| rsworkspace/crates/trogonai-proto/src/gen/mod.rs | Wires agent package modules into the overall generated module tree. |
| rsworkspace/crates/trogonai-proto/src/agents/mod.rs | Adds agents top-level wrapper module. |
| rsworkspace/crates/trogonai-proto/src/agents/agents/mod.rs | Re-exports agent v1/state types and defines stable type URL/schema constants. |
| rsworkspace/crates/trogonai-proto/src/agents/agents/codec/tests.rs | Adds tests for encoding/decoding agent event payloads and dispatch behavior. |
| rsworkspace/crates/trogonai-proto/src/agents/agents/codec.rs | Implements trogon_decider event traits for the agent event envelope. |
| rsworkspace/crates/trogonai-proto/Cargo.toml | Introduces agents feature and dependencies for agent proto support. |
| rsworkspace/crates/trogonai-agents-domain/src/lib.rs | New crate root for the provisioning domain surface. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/test_support.rs | Test helpers for constructing valid commands/events/digests. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/provision_agent/tests.rs | Decider-level tests for provisioning behavior and retry classification. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/provision_agent.rs | Provisioning Decider implementation (decide/evolve/state). |
| rsworkspace/crates/trogonai-agents-domain/src/commands/proto_wire/tests.rs | Tests for wire↔domain conversion and validation errors. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/proto_wire.rs | Wire conversion layer, including deterministic ordering/uniqueness checks. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/mod.rs | Commands module layout and public exports. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/event_fold/tests.rs | Tests for event payload extraction and identity mismatch handling. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/event_fold.rs | Helpers for folding/extracting the provisioning payload from the event envelope. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/tool_selectors/tests.rs | Validation tests for tool selector sets. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/tool_selectors.rs | Domain type enforcing nonblank/disjoint tool selector sets. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/runtime_id/tests.rs | Runtime id validation/conversion tests. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/runtime_id.rs | Runtime id value object. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/revision_number/tests.rs | Revision number validation/ordering tests. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/revision_number.rs | Revision number value object with genesis constant. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/principal/tests.rs | Principal validation tests. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/principal.rs | Principal value object enforcing trimming/length constraints. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/parent_ref/tests.rs | Parent reference validation/conversion tests. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/parent_ref.rs | Parent reference value object. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/nonblank.rs | Shared nonblank/trimmed validation utility. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/model_parameters/tests.rs | Model parameter validation tests. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/model_parameters.rs | Model parameter map wrapper validating keys are nonblank/trimmed. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/model_id/tests.rs | Model id validation/conversion tests. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/model_id.rs | Model id value object. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/mod.rs | Domain module composition and exports. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/labels/tests.rs | Kubernetes label syntax tests and ordering checks. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/labels.rs | Labels value object enforcing Kubernetes qualified-name/value syntax. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/kubernetes_syntax.rs | Kubernetes qualified-name / label-value validators. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/delegate_selectors/tests.rs | Validation tests for delegate selector sets. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/delegate_selectors.rs | Domain type enforcing nonblank/disjoint delegate selector sets. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/content_digest/tests.rs | Digest parsing tests, including invalid prefix/hex cases. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/content_digest.rs | Content digest value object enforcing canonical sha256:<64 hex> format. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/annotations/tests.rs | Annotation ordering/validation tests. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/annotations.rs | Annotations value object enforcing Kubernetes qualified-name keys. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_name/tests.rs | Agent name validation/conversion tests. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_name.rs | Agent name value object. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_id/tests.rs | Agent id validation/conversion tests. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_id.rs | Agent id value object enforcing non-empty/trimmed input. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_definition/tests.rs | Composition tests for the validated agent definition aggregate. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_definition.rs | Agent definition aggregate (name/parent/owner/labels/annotations/charter). |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_charter/tests.rs | Charter composition tests. |
| rsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_charter.rs | Agent charter aggregate (runtime/model/tools/delegates). |
| rsworkspace/crates/trogonai-agents-domain/Cargo.toml | New crate manifest and dependencies on trogonai-proto with agents feature. |
| rsworkspace/Cargo.lock | Adds the new trogonai-agents-domain package to the workspace lockfile. |
| proto/trogonai/agents/agents/v1/provision_agent.proto | Adds provisioning command proto definition. |
| proto/trogonai/agents/agents/v1/events.proto | Adds agent event union proto definition. |
| proto/trogonai/agents/agents/v1/agent.proto | Adds shared agent v1 types (charter/model/labels/etc). |
| proto/trogonai/agents/agents/v1/agent_provisioned.proto | Adds genesis provisioning event proto definition. |
| proto/trogonai/agents/agents/state/v1/provision_agent_state.proto | Adds state snapshot proto definition for provisioning decider state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yordis
force-pushed
the
yordis/audit-agent-context-doc
branch
from
July 22, 2026 05:14
e5c8969 to
8496fa8
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 70 out of 71 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
rsworkspace/crates/agents/trogonai-agents-domain/src/commands/domain/content_digest.rs:30
ContentDigest::parseusesraw.len()(byte length) to enforce thesha256:<64 hex>length, but reportsactualusinghex.chars().count(). If the digest contains any non-ASCII character, this can incorrectly returnInvalidLength { actual: 64 }(because a multi-byte char can keep the char-count at 64 while the byte-length differs), and it also prevents the more accurateInvalidHexpath from triggering. Consider checking the character count instead of byte length for the length gate.
if raw.len() != ENCODED_LENGTH {
return Err(ContentDigestError::InvalidLength {
actual: hex.chars().count(),
});
}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@rsworkspace/crates/trogonai-agents-domain/src/commands/event_fold.rs`:
- Around line 6-15: Change AgentEventFoldError::AgentIdMismatch.expected from
String to AgentId, and update its construction sites to pass the existing
AgentId directly rather than converting it with as_str().to_string(). Preserve
the error message formatting and keep actual as the validated AgentId domain
type.
In `@rsworkspace/crates/trogonai-agents-domain/src/commands/mod.rs`:
- Around line 1-9: The exported ProvisionAgent API exposes AgentEventFoldError,
but the error type is not publicly reachable from the crate root. Add the
re-export in commands/mod.rs and then re-export it from lib.rs; no direct change
is needed in
rsworkspace/crates/trogonai-agents-domain/src/commands/provision_agent.rs lines
22-39 because it is evidence of the exposed type.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6cd9d23d-3ac8-442f-87ca-550db12292db
⛔ Files ignored due to path filters (16)
rsworkspace/Cargo.lockis excluded by!**/*.lockrsworkspace/crates/trogonai-proto/src/gen/mod.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.state.v1.mod.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.state.v1.provision_agent_state.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.state.v1.provision_agent_state.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.agent.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.agent.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.agent_provisioned.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.agent_provisioned.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.events.__oneof.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.events.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.events.__view_oneof.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.events.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.mod.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.provision_agent.__view.rsis excluded by!**/gen/**rsworkspace/crates/trogonai-proto/src/gen/trogonai.agents.agents.v1.provision_agent.rsis excluded by!**/gen/**
📒 Files selected for processing (55)
proto/trogonai/agents/agents/state/v1/provision_agent_state.protoproto/trogonai/agents/agents/v1/agent.protoproto/trogonai/agents/agents/v1/agent_provisioned.protoproto/trogonai/agents/agents/v1/events.protoproto/trogonai/agents/agents/v1/provision_agent.protorsworkspace/crates/trogonai-agents-domain/Cargo.tomlrsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_charter.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_charter/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_definition.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_definition/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_id.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_id/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_name.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_name/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/annotations.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/annotations/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/content_digest.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/content_digest/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/delegate_selectors.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/delegate_selectors/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/kubernetes_syntax.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/labels.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/labels/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/mod.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/model_id.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/model_id/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/model_parameters.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/model_parameters/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/nonblank.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/parent_ref.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/parent_ref/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/principal.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/principal/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/revision_number.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/revision_number/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/runtime_id.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/runtime_id/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/tool_selectors.rsrsworkspace/crates/trogonai-agents-domain/src/commands/domain/tool_selectors/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/event_fold.rsrsworkspace/crates/trogonai-agents-domain/src/commands/event_fold/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/mod.rsrsworkspace/crates/trogonai-agents-domain/src/commands/proto_wire.rsrsworkspace/crates/trogonai-agents-domain/src/commands/proto_wire/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/provision_agent.rsrsworkspace/crates/trogonai-agents-domain/src/commands/provision_agent/tests.rsrsworkspace/crates/trogonai-agents-domain/src/commands/test_support.rsrsworkspace/crates/trogonai-agents-domain/src/lib.rsrsworkspace/crates/trogonai-proto/Cargo.tomlrsworkspace/crates/trogonai-proto/src/agents/agents/codec.rsrsworkspace/crates/trogonai-proto/src/agents/agents/codec/tests.rsrsworkspace/crates/trogonai-proto/src/agents/agents/mod.rsrsworkspace/crates/trogonai-proto/src/agents/mod.rsrsworkspace/crates/trogonai-proto/src/lib.rsrsworkspace/crates/trogonai-proto/src/tests.rs
🚧 Files skipped from review as they are similar to previous changes (33)
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/model_parameters/tests.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_definition/tests.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/runtime_id/tests.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/delegate_selectors/tests.rs
- rsworkspace/crates/trogonai-agents-domain/Cargo.toml
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/revision_number/tests.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_id/tests.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/tool_selectors/tests.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/content_digest/tests.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/parent_ref/tests.rs
- rsworkspace/crates/trogonai-proto/Cargo.toml
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/nonblank.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_charter/tests.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/model_id/tests.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/labels/tests.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/delegate_selectors.rs
- proto/trogonai/agents/agents/v1/agent.proto
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/runtime_id.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/labels.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/model_parameters.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_id.rs
- rsworkspace/crates/trogonai-proto/src/agents/mod.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_charter.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/model_id.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/tool_selectors.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/parent_ref.rs
- rsworkspace/crates/trogonai-proto/src/agents/agents/codec.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/content_digest.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/principal/tests.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/kubernetes_syntax.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/agent_name.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/principal.rs
- rsworkspace/crates/trogonai-agents-domain/src/commands/domain/annotations.rs
Land the agent lifecycle domain under the crates/<group> topology from ADR#0034: the domain crate in crates/agents/ and its generated proto in crates/platform/trogonai-proto/, so the agents family follows the accepted grouping rather than the pre-reorg flat layout. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/audit-agent-context-doc
branch
from
July 26, 2026 17:34
8496fa8 to
01f3851
Compare
…ntext-doc Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com> # Conflicts: # rsworkspace/crates/platform/trogonai-proto/src/lib.rs # rsworkspace/crates/platform/trogonai-proto/src/tests.rs
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a6032b4. Configure here.
What a charter can configure (model, parameters, tool and delegate declarations) is defined by the runtime, so the fixed shape did not fit across engines. Carry a single runtime-owned configuration Any that the named runtime defines and validates; absent means the runtime's defaults. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
`charter` names a change-classification in the design (charter-class vs learned-layer), not a record, so it misread as a message name. Use the sanctioned record term AgentConfiguration and name its runtime-owned Any `settings`. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Agents need an identity provable anywhere without a central authority; adopt a self-certifying keypair as the name (DID/thumbprint), bound at registration by proof-of-possession and verified on the existing AAuth plane, so global uniqueness and verifiability are intrinsic. Deferred: attestation, global resolution, and key rotation. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
ADR#0036 left three questions open that would be re-litigated without a record: which governance half of the Nostr model applies, which crypto suite realizes the property without foreclosing migration, and how authorship proof travels with events instead of resting on the append path. The three records are mutually referential, so they land together, and ADR#0036 now points forward at them. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
No consumer should need contract folklore to know which revision a genesis event minted; a fact a reader needs is a field on the event, and the one-legal-value invariant is enforced at write time by the decider instead of assumed by every reader. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
One concept was spelled three ways (name, title, an annotations key) and a field called name promised resolution nothing performed. ADR#0040 pins a two-question vocabulary for identifiers, handles, and display labels, and greenfield pays the breaking renames once, before anything deployed depends on the old spellings. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.